Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add new imagestreams to inlude Code-Server and R-Studio #844

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Add new imagestreams to inlude Code-Server and R-Studio #844

merged 1 commit into from
Jun 22, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 13, 2023 •
edited
Loading

This PR introduces the Code-Server (VS-Code) and R-Studio workbench images into OOTB.

Related issue: https://github.com/opendatahub-io/odh-manifests/issues/843

Description

How Has This Been Tested?

  • Deploy ODH with the additional overlay enabled for notebook-images
  - kustomizeConfig:
      overlays:
      - additional
      repoRef:
        name: manifests
        path: notebook-images
    name: notebook-images
  • Login to odh-dashboard and spawn a notebook Code Server, R Studio or Cuda R Studio
  • Confirm that the notebook spawned successfully and its functionality works

Screenshot from 2023-06-20 14-30-27

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member Author

atheo89 commented Jun 13, 2023 •
edited
Loading

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Hold off on merging (provide reason in comment) label Jun 13, 2023
@atheo89 atheo89 force-pushed the add-rstudio-vscode-imagestreams branch 11 times, most recently from 9dd6e82 to e5e14b1 Compare June 20, 2023 15:58
@LaVLaS LaVLaS mentioned this pull request Jun 20, 2023
Closed
9 tasks
@atheo89 atheo89 force-pushed the add-rstudio-vscode-imagestreams branch 4 times, most recently from a6c25ea to 51d43e3 Compare June 21, 2023 11:31
@atheo89
Copy link
Member Author

atheo89 commented Jun 21, 2023 •
edited
Loading

/unhold
It's ready for review @LaVLaS @VaishnaviHire

@openshift-ci openshift-ci bot removed the do-not-merge/hold Hold off on merging (provide reason in comment) label Jun 21, 2023
@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 21, 2023

@harshad16 @atheo89 The main question is is we want to support these notebooks Core deployment. Can you move the new notebooks to an optional notebook overlay so that they are "opt-in" for the user

@atheo89
Copy link
Member Author

atheo89 commented Jun 21, 2023 •
edited
Loading

@LaVLaS Sure! Is it fine if we move them to the overlays/additional directory?

@harshad16
Copy link
Member

@LaVLaS can you guide us a little here,
we want to provide them with Tier 1 in ODH, should these be in the base layer itself, along with other OOTB images.
isn't place them in overlays makes them same as the opendatahub-io-contrib?

@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 21, 2023

@LaVLaS can you guide us a little here, we want to provide them with Tier 1 in ODH, should these be in the base layer itself, along with other OOTB images. isn't place them in overlays makes them same as the opendatahub-io-contrib?

@harshad16 These notebooks would be included the same additional overlay as the Elyra notebook.

@atheo89 atheo89 force-pushed the add-rstudio-vscode-imagestreams branch 2 times, most recently from b06b61b to 6164c75 Compare June 22, 2023 07:36
@atheo89
Introduce imagestreams that inlude vs-code and r studio workbenches i…
6e8e667 
…nto OOTB

Move vscode and rstudio on the additional layer
@atheo89 atheo89 force-pushed the add-rstudio-vscode-imagestreams branch from 6164c75 to 6e8e667 Compare June 22, 2023 07:41
@atheo89
Copy link
Member Author

atheo89 commented Jun 22, 2023

@LaVLaS @harshad16 PTAL

@atheo89
Copy link
Member Author

atheo89 commented Jun 22, 2023

/retest-required

harshad16
harshad16 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Jun 22, 2023
@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 22, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2eebc37 into opendatahub-io:master Jun 22, 2023
@shalberd
Copy link
Contributor

@LaVLaS Elyra should not really be in additional anymore in that form ... it's part of all base images now.
Cool to see Guillome's R Studio from contrib in additional now

@harshad16
Copy link
Member

Elyra should not really be in additional anymore in that form ... it's part of all base images now. Cool to see Guillome's R Studio from contrib in additional now

It would be removed in the next release cycle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@LaVLaS LaVLaS Awaiting requested review from LaVLaS

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atheo89 @LaVLaS @harshad16 @shalberd @openshift-merge-robot